Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

check if element exists before focusing added #2056

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

adoroshk
Copy link
Contributor

Summary

This PR adds a check if row and cell element exist before focusing on the last one. That allows to avoid errors in cases the cell implementation is different from documented.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

This PR resolves:
MPAGESCORE-91600

@github-actions github-actions bot temporarily deployed to preview-pr-2056 February 28, 2024 22:12 Destroyed
@adoroshk adoroshk merged commit cb3e36a into main Feb 29, 2024
22 checks passed
@adoroshk adoroshk deleted the compact-interactive-list-menu-button-click-error branch February 29, 2024 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants