Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[Date-Time-Picker] Month/Year changing redundant announcement fix #2057

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

ashishkumbhare116
Copy link
Contributor

@ashishkumbhare116 ashishkumbhare116 commented Feb 29, 2024

Summary

Currently when navigating through the Date Picker popup and selecting a value for "Month"/ "Year", will only expose the selected value. But, the selected value is getting exposed twice as "February, Month Combobox February", .

What was changed:

Why it was changed:

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2057 March 1, 2024 03:01 Destroyed
@ashishkumbhare116 ashishkumbhare116 changed the title DateTimePicker month/year redundand reading fix [Date-Time-Picker] Month/Year changing redundant reading fix Mar 1, 2024
@ashishkumbhare116 ashishkumbhare116 changed the title [Date-Time-Picker] Month/Year changing redundant reading fix [Date-Time-Picker] Month/Year changing redundant announcement fix Mar 1, 2024
@ashishkumbhare116 ashishkumbhare116 marked this pull request as ready for review March 1, 2024 04:40
@sugan2416
Copy link
Contributor

sugan2416 commented Mar 1, 2024

Announcing once as expected
Screenshot 2024-03-01 at 3 49 53 PM

@SwethaM03
Copy link

+1
As per PR, the issues are fixed and working as expected. However when the drop down is expanded for month and year combobox, the instruction to use the arrow keys are read out for each option present in the dropdown which is incorrect.
And I observed that 'Open Calendar' button name getting announced multiple times while navigating to the Calendar button.

@sugan2416 sugan2416 merged commit cb1603e into main Mar 1, 2024
22 checks passed
@sugan2416 sugan2416 deleted the datePickerRedundantfix branch March 1, 2024 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants