-
Notifications
You must be signed in to change notification settings - Fork 72
[terra-table] Rerganized Cell.jsx for easier maintenance & readability #2061
Conversation
Are these changes necessary? It might make it harder to maintain to have manually added headers for code. I feel like some of the headers would make it confusing where to add code. |
Test failures are due to other wdio components. The jest tests passing indicate that the cell.jsx is still functionally identical after this change. |
@cm9361 The headers help to indicate what each block of code does at a glance, but I can remove them if it can cause more confusion in the future. Besides the headers, these changes are mainly grouping functionally similar code together to minimize jumping back and forth, such as putting all DOM related variables at the end. |
Summary
This PR reorganizes the cell.jsx file for easier maintenance & readability by moving the code into labelled sections. There are no functional changes in this PR.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Thank you for contributing to Terra.
@cerner/terra