Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-navigation-side-menu] Example Update #2063

Merged
merged 13 commits into from
Mar 20, 2024
Merged

Conversation

MadanKumarGovindaswamy
Copy link
Contributor

@MadanKumarGovindaswamy MadanKumarGovindaswamy commented Mar 5, 2024

Summary

What was changed:

Updated navigation-side-menu example.

Why it was changed:

Example does not convey name, role, value of the control.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 5, 2024 07:51 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 5, 2024 08:04 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 5, 2024 11:15 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 5, 2024 11:34 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 5, 2024 11:45 Destroyed
@MadanKumarGovindaswamy MadanKumarGovindaswamy changed the title Update: Navigation side menu issues [terra-navigation-side-menu] Example Update Mar 5, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 6, 2024 07:02 Destroyed
@MadanKumarGovindaswamy MadanKumarGovindaswamy marked this pull request as ready for review March 6, 2024 08:17
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 11, 2024 04:39 Destroyed
This reverts commit d687859, reversing
changes made to 6a53803.
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 11, 2024 04:58 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 11, 2024 05:11 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 11, 2024 05:16 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 19, 2024 04:59 Destroyed
@allanxavierm
Copy link
Collaborator

allanxavierm commented Mar 19, 2024

@MadanKumarGovindaswamy You may have to resolve the merge conflict here

@github-actions github-actions bot temporarily deployed to preview-pr-2063 March 19, 2024 08:44 Destroyed
@rbsree
Copy link

rbsree commented Mar 20, 2024

+1, the issue mentioned in the PR is fixed.

But there are few issue I found in the Terra Side Menu navigation component.

Issues:

  • When an menuitem is selected it SR does read message as "--menuitem, selected", but when user navigates away and back to the selected menutiem the selected state is not exposed to users.
  • Back button present in the submenu control doesn't have a contextual label.
  • When user lands on 'Hospital Services' sub menu- The instructions to activate with enter / space key is not announced. - (Default behaviour, checked with https://www.w3.org/WAI/ARIA/apg/patterns/menu-button/examples/menu-button-links/)

@sugan2416 sugan2416 merged commit 1cf07ac into main Mar 20, 2024
22 checks passed
@sugan2416 sugan2416 deleted the NavigationSideMenuIssues branch March 20, 2024 07:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants