Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[Terra-Date-Picker] - Fixed Time input and Date picker displays incorrectly in firefox. #2064

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

PK106552
Copy link
Contributor

@PK106552 PK106552 commented Mar 5, 2024

Summary

What was changed:

  • Up/Down arrow has been removed in Time input and date picker input field in firefox.

Why it was changed:

  • Time input and Date picker displays incorrectly in firefox.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10286


Thank you for contributing to Terra.
@cerner/terra

Befor fix:

Screenshot 2024-03-05 at 12 12 47 PM

After Fix:

Screenshot 2024-03-05 at 12 13 04 PM

@PK106552 PK106552 self-assigned this Mar 5, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2064 March 5, 2024 08:16 Destroyed
@kenk2 kenk2 requested a review from a team March 5, 2024 16:45
Copy link
Contributor

@kenk2 kenk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to preview-pr-2064 March 6, 2024 03:23 Destroyed
@saket2403 saket2403 merged commit b4b9f88 into main Mar 6, 2024
22 checks passed
@saket2403 saket2403 deleted the datePicker_firefox_issue branch March 6, 2024 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants