This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-abstract-modal] [terra-modal-manager] Revert Focus Trap Changes #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
changed the title
cm9361
reviewed
Mar 5, 2024
| /** | ||
| * If set to true, then the outside click will get enabled. | ||
| */ | ||
| closeOnOutsideClick: PropTypes.bool, |
There was a problem hiding this comment.
This change will break MPages
There was a problem hiding this comment.
Communicated: These changes are requirements for v4. Meanwhile this is being done so that v3 consumers do not break with focus trapping.
|
Is there a branch where the focus changes are added for easy re-adding? |
@sdadn I have a branch set up at |
JessieRandle
approved these changes
Mar 5, 2024
sdadn
approved these changes
Mar 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Reverts: #2014
Why it was changed:
UX wants us to implement focus trap changes in terra-abstract-modal v4. Focus Trapping is not a requirement in v3 of the components.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
Thank you for contributing to Terra.
@cerner/terra