Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-abstract-modal][terra-modal-manager] Add Focus Trap #2068

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

kenk2
Copy link
Contributor

@kenk2 kenk2 commented Mar 6, 2024

Summary

What was changed:
Re-introduce focus trapping changes in terra-abstract-modal made in 3.47.0

Why it was changed:
To help consumers who are utilizing the focus trapping workflows that were introduced earlier by mistake.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@kenk2 kenk2 self-assigned this Mar 6, 2024
@kenk2 kenk2 requested a review from a team March 6, 2024 17:56
@github-actions github-actions bot temporarily deployed to preview-pr-2068 March 6, 2024 17:56 Destroyed
@kenk2 kenk2 marked this pull request as ready for review March 6, 2024 19:19
@kenk2 kenk2 removed the do not merge label Mar 7, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2068 March 7, 2024 15:25 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2068 March 7, 2024 20:24 Destroyed
@kenk2 kenk2 merged commit a8ab03a into main Mar 7, 2024
22 checks passed
@kenk2 kenk2 deleted the abstract-modal-mvb branch March 7, 2024 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants