Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[compact-interactive-list] Support for menu button #2073

Merged
merged 13 commits into from
Mar 13, 2024

Conversation

adoroshk
Copy link
Contributor

@adoroshk adoroshk commented Mar 8, 2024

This PR adds support for terra-menu inside a terra-compact-interactive-list cell.

Both components - terra-compact-interactive-list and terra-menu - have their own keyboard navigation events, which needed to be preserved once Menu Button is placed inside the Compact Interactive list.

What was changed:

  • the keyDown event propagation was stopped inside the Menu Button component to not trigger Compact Interactive list keyDown events on bubbling phase.
  • the Compact interactive list cell onClick e.preventDefault was removed as it was blocking menu onClick event.
  • the wdio tests were added to verify the menu button is keyboard accessible inside the Compact Interactive list.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10218

… compact-interactive-list-support-menu-button
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 8, 2024 18:55 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 8, 2024 19:08 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 8, 2024 21:05 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 8, 2024 21:24 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 11, 2024 21:44 Destroyed
@adoroshk adoroshk marked this pull request as ready for review March 11, 2024 22:00
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 11, 2024 22:45 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 11, 2024 23:29 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 12, 2024 01:48 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 12, 2024 02:51 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 12, 2024 20:21 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2073 March 12, 2024 20:35 Destroyed
@adoroshk adoroshk merged commit c165698 into main Mar 13, 2024
22 checks passed
@adoroshk adoroshk deleted the compact-interactive-list-support-menu-button branch March 13, 2024 19:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants