This repository has been archived by the owner on May 24, 2024. It is now read-only.
[compact-interactive-list] hasVisibleBorders prop added #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdadn
reviewed
Mar 13, 2024
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Added | |||
| * Added `hasVisibleBorders` prop. | |||
There was a problem hiding this comment.
Can we add a the purpose of the prop as well? e.g. Added hasVisibleBorders prop to .....
There was a problem hiding this comment.
Updated in 27d253d
sycombs
reviewed
Mar 13, 2024
packages/terra-compact-interactive-list/src/subcomponents/Row.jsx
Outdated
Show resolved
Hide resolved
sycombs
changed the title
sdadn
approved these changes
Mar 13, 2024
sycombs
approved these changes
Mar 13, 2024
… compact-interactive-list-borderless-add-prop
…//github.com/cerner/terra-framework into compact-interactive-list-borderless-add-prop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
hasVisibleBordersprop and a test example for it.What was changed:
hasVisibleBordersprop added.hasVisibleBordersdefaults to true.hasVisibleBordersremoves row borders and row backgroundTesting
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10300