Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-data-grid] Added event object to onCellSelect callback #2077

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

saket2403
Copy link
Contributor

@saket2403 saket2403 commented Mar 13, 2024

Summary

What was changed:
Added event object to onCellSelect callback

Why it was changed:
MPages want event object to stop the event in certain scenarios.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10299


Thank you for contributing to Terra.
@cerner/terra

@saket2403 saket2403 self-assigned this Mar 13, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2077 March 13, 2024 11:25 Destroyed
@sdadn
Copy link
Contributor

sdadn commented Mar 13, 2024

Do we need to add this change to the documentation?

@saket2403
Copy link
Contributor Author

Do we need to add this change to the documentation?

I updated the prop description for onCellSelect with parameter details.

@allanxavierm allanxavierm merged commit 448cf58 into main Mar 14, 2024
22 checks passed
@allanxavierm allanxavierm deleted the data-grid-event branch March 14, 2024 08:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants