This repository has been archived by the owner on May 24, 2024. It is now read-only.
time input tests fix #2078
Merged
time input tests fix #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All checks passed from the first attempt. Re-running checks to ensure it wasn't accidental. |
|
Re-running tests passed as well. I guess that means that a fix to seconds increment/decrement testing will fix the tests failure. |
sycombs
approved these changes
Mar 13, 2024
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, if the time input has no time entered, per "+" key press it fills the time with current time +1 second. If "-" pressed -1 second.
The wdio tests for that functionality are checking if the input time is in 2 seconds range from expected value, using real time instead of mocked value, which caused tests failure in 80% of cases.
This PR is temporary fix to prevent delays caused by tests failures. It replaces check for seconds be in proper time range to check for seconds to have a value in between 0 and 59. The tests needs to be updated with proper check for seconds being +1/-1 compared to current time, where current time is properly mocked. That work should be done as a part of UXPLATFORM-10295.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR is temporary fix to prevent delays caused by tests failures. It replaces check for seconds be in proper time range to check for seconds to have a value in between 0 and 59. The tests needs to be updated with proper check for seconds being +1/-1 compared to current time, where current time is properly mocked. That work should be done as a part of UXPLATFORM-10295.