Update WDIO snapshots #2081
Update WDIO snapshots #2081
Conversation
saket2403
changed the title
There was a problem hiding this comment.
Why is the old blue focus used instead of dashed border ?
There was a problem hiding this comment.
Looks to me like it's using the default focus style from terra-form-input for some reason. I'm not sure why since there haven't been any changes to terra-form-input for quite some time.
https://github.com/cerner/terra-core/blob/main/packages/terra-form-input/src/Input.module.scss#L51
There was a problem hiding this comment.
This might be the reason WDIO applies wrong border: https://github.com/cerner/terra-framework/pull/2064/files
There was a problem hiding this comment.
But it is only mozilla specific styling and not applied to date input
|
Looks like the new screenshots are correct; it is cause by a styling defect when shifting focus from date-input -> date-input-field -> date-input and it was reproducible on multiple devices. We should merge this change for now since screenshots should represent the "current" state of code and correct the defect at a later date. |
Summary
What was changed:
Fixed wdio snapshots failing on main
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra