This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-collapsible-menu-view] Table flickering issue in Collapsible menu view #2086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadanKumarGovindaswamy
changed the title
This reverts commit 28f1414.
saket2403
reviewed
Mar 18, 2024
| * @private | ||
| * Allows to reset cache and elements will be rendered face-up for width calculations. | ||
| */ | ||
| allowResetCache: PropTypes.bool, |
There was a problem hiding this comment.
Why is this prop required if the default value is true?
There was a problem hiding this comment.
In mpage application side, they don't need this reset cache method to execute. so kept this as a internal prop. where they can send as false.
saket2403
approved these changes
Mar 18, 2024
allanxavierm
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Since resizeObserver is used to provide the available space for calculations, It does not provide the right value when the component is wrapped with other terra components, so replacing with the container width to use it for calculation.
Why it was changed:
When the Collapsible menu view component is used with in table, as the component loads flicker the screen continuously and let the user cannot click on any action buttons with in the button.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10292
Thank you for contributing to Terra.
@cerner/terra