Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-menu] Added position prop to control HookshotContent positioning #2092

Closed
wants to merge 14 commits into from

Conversation

adavijit
Copy link
Collaborator

@adavijit adavijit commented Mar 20, 2024

Summary

What was changed:

  • Added hookshotContentPosition prop in Menu to control positioning strategy for the menu content when used with Hookshot. (default hookshotContentPosition value is passed as fixed)
  • Added ...customProps to get the hookshotContentPosition prop passed from Menu component
  • Added position prop to specify the CSS position property value to be applied to the HookshotContent.

Why it was changed:

Opening Large Menu and navigated back to main menu from submenu, white space appears at the bottom causing page shift.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

image

This PR resolves:

UXPLATFORM-10055


Thank you for contributing to Terra.
@cerner/terra

@adavijit adavijit self-assigned this Mar 20, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 06:59 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 09:33 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 09:39 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 09:59 Destroyed
@adavijit adavijit changed the title [terra-menu] Added position props to control HookshotContent positioning [terra-menu] Added position prop to control HookshotContent positioning Mar 20, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 11:10 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 20:30 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 20, 2024 22:11 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2092 March 21, 2024 06:50 Destroyed
@adavijit adavijit closed this Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants