Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-table] [terra-data-grid] Add column span functionality to FlowsheetDataGrid and Table #2096

Merged
merged 53 commits into from
Apr 16, 2024

Conversation

nikhitasharma
Copy link
Contributor

@nikhitasharma nikhitasharma commented Mar 20, 2024

Summary

What was changed:
Added column span functionality to Terra Table to support it in FlowsheetDataGrid

Notes:

  • The column highlighting functionality is disabled for columns with multiple column spans.
    The below example has column highlighting for Illness Severity but will not be supported since it has column span of 2.
    image

Why it was changed:
To support multiple column spans and avoid histories to break on page loads.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10182


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 20, 2024 21:10 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 20, 2024 21:48 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 21, 2024 00:24 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 21, 2024 03:13 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 21, 2024 14:04 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 21, 2024 14:39 Destroyed
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are column actions supposed to be unsupported with columnSpan prop? I checked that in current implementation column actions don't work with column span, but in documentation I don't see a mentioning it's not supported, like, for example, Column Highlighting functionality.

@github-actions github-actions bot temporarily deployed to preview-pr-2096 March 21, 2024 18:43 Destroyed
@nikhitasharma
Copy link
Contributor Author

Are column actions supposed to be unsupported with columnSpan prop? I checked that in current implementation column actions don't work with column span, but in documentation I don't see a mentioning it's not supported, like, for example, Column Highlighting functionality.

Thats a good catch, It is simple prop addition for column actions header to support column spans. I have added that in and it should work now:
image

@mjpalazzo
Copy link
Contributor

@nikhitasharma - Should column header actions such as sort disabled for column span?

@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 15:26 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 15:35 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 16:01 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 16:07 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 17:05 Destroyed
@mjpalazzo
Copy link
Contributor

@nikhitasharma - I validated keyboard navigation and JAWS using the Edge browser. Everything is working as required. The issue in the column actions example where the button label does not match the column header is still there, but that is a minor issue with the example not the component.
Great job!

@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 20:54 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 21:01 Destroyed
@nikhitasharma
Copy link
Contributor Author

@nikhitasharma - I validated keyboard navigation and JAWS using the Edge browser. Everything is working as required. The issue in the column actions example where the button label does not match the column header is still there, but that is a minor issue with the example not the component. Great job!

Thanks for pointing that out clearly. I fixed it.

@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 21:09 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 21:35 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 21:49 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2096 April 16, 2024 22:50 Destroyed
@nikhitasharma nikhitasharma merged commit 175265e into main Apr 16, 2024
22 checks passed
@nikhitasharma nikhitasharma deleted the fdg-column-span branch April 16, 2024 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants