-
Notifications
You must be signed in to change notification settings - Fork 72
[terra-table] [terra-data-grid] Add column span functionality to FlowsheetDataGrid and Table #2096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are column actions supposed to be unsupported with columnSpan
prop? I checked that in current implementation column actions don't work with column span, but in documentation I don't see a mentioning it's not supported, like, for example, Column Highlighting functionality.
...-site/doc/data-grid/FlowsheetDataGrid.4/Examples.6/FlowsheetDataGridWithColumnSpan.7.doc.mdx
Outdated
Show resolved
Hide resolved
@nikhitasharma - Should column header actions such as sort disabled for column span? |
@nikhitasharma - I validated keyboard navigation and JAWS using the Edge browser. Everything is working as required. The issue in the column actions example where the button label does not match the column header is still there, but that is a minor issue with the example not the component. |
Thanks for pointing that out clearly. I fixed it. |
Summary
What was changed:
Added column span functionality to Terra Table to support it in FlowsheetDataGrid
Notes:
The below example has column highlighting for Illness Severity but will not be supported since it has column span of 2.
Why it was changed:
To support multiple column spans and avoid histories to break on page loads.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10182
Thank you for contributing to Terra.
@cerner/terra