Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-menu] Fixed Whitespace issue in Large Menu #2098

Merged
merged 11 commits into from
Mar 25, 2024

Conversation

adavijit
Copy link
Collaborator

Summary

What was changed:

  • Added conditional class to the HookshotContent component based on the prop hookshotPostionFixed
  • Added prop to allow accepting and passing additional props to the Popup component.
  • Added and passed hookshotPostionFixed prop to set HookshotCoontent position to fixed.

Why it was changed:

Opening Large Menu and navigated back to main menu from submenu, white space appears at the bottom causing page shift.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

image

This PR resolves:

UXPLATFORM-10055


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 10:23 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 11:25 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 11:46 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 11:53 Destroyed
@adavijit adavijit requested a review from sugan2416 March 21, 2024 11:58
@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 12:01 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2098 March 21, 2024 12:29 Destroyed
@saket2403 saket2403 merged commit debd27c into main Mar 25, 2024
22 checks passed
@saket2403 saket2403 deleted the UXPLATFORM-10055_fix_terra-menu branch March 25, 2024 06:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants