This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-table] Allow spacebar to trigger click event for buttons inside table cells #2101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Mar 21, 2024
sdadn
approved these changes
Mar 22, 2024
chrismichalewicz
added
⭐ Functionally Reviewed
and removed
Functional Review Required
labels
|
@cm9361 This has been functionally reviewed, looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Fixed an issue where the click event for buttons inside table cells was not triggered by the spacebar.
Why it was changed:
The change was made to meet necessary accessibility requirements.
Testing
This change was tested using:
The functionality was tested via our focusable cell examples.
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10321
Thank you for contributing to Terra.
@cerner/terra