-
Notifications
You must be signed in to change notification settings - Fork 72
Conversation
Co-authored-by: Saad Adnan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make sure we are on the same page here, a double-check on terminology. Under select the cell we mean set focus to the whole cell, not change cells isSelected prop by calling onCellSelect method? I am approving presuming the above, as it's works as expected.
Yes, that is correct. |
@cm9361 - Thanks for turning this around so quickly. The Escape key interaction is working well. My only concern is that the screen reader user does not know this interaction is available. I am not sure what the best way is to provide this helper text. Since the focus is on the button or hyperlink, JAWS announces how to interact with those elements appropriately. |
@cm9361 - JAWS announcement when focus is on the button is better. Here is a what I heard: |
The latest version is working as required. When I pressed Escape, JAWS announced the cell contents and "Table navigation resumed." Thanks also for fixing the text in the column headers. |
Summary
What was changed:
Added the ability to select a cell by pressing Escape on an auto focused button or anchor element.
Why it was changed:
The change was made due to a functional requirement where consumers need to ability to select the cell and the button element.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10323
Thank you for contributing to Terra.
@cerner/terra