This repository has been archived by the owner on May 24, 2024. It is now read-only.
[compact-interactive-list] Examples updated to remove redundant button announcement. #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm9361
approved these changes
Mar 28, 2024
sycombs
approved these changes
Mar 28, 2024
saket2403
deleted the
compact-interactive-list-fix-redundant-button-announcement
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
terra-compact-interactive-listexamples to remove the word "button" from terra-button text, which was leading to the word "button" to be announced twice.Previously Featured buttons (represented by star icon in examples), had text that would read "Featured button". That text would be announced by assistive technologies, followed by the second "button" word, to indicate that it was a button element. The text was replaced to read "Favorite Item", hence the full announcement changed to be "Favorite Item Button".
Testing
This change was tested using:
To test with JAWS, in Compact Interactive List examples tab to the compact interactive list, then using arrow keys navigate to the star icon:
The announcement should be "Favorite Item Button", not "Featured Button Button".
Reviews
In addition to engineering reviews, this PR needs:
This PR resolves:
UXPLATFORM-10261