This repository has been archived by the owner on May 24, 2024. It is now read-only.
[compact interactive list ] No row headers if list has only one semantic column #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Mar 29, 2024
| columns={singleCol} | ||
| />, | ||
| ); | ||
| expect(wrapper).toMatchSnapshot(); |
There was a problem hiding this comment.
Nit: IIRC we are kind of moving away from doing these kinds of snapshot tests? These tend to be hard to verify and we just overwrite the results anyways.
There was a problem hiding this comment.
I added the snapshot to ensure the component rendered with correct role, but jest test checks the same so I am willing to remove it. It is a bit extra.
There was a problem hiding this comment.
Removed in 76ce35a
sycombs
reviewed
Mar 29, 2024
packages/terra-compact-interactive-list/src/CompactInteractiveList.jsx
Outdated
Show resolved
Hide resolved
…List.jsx Co-authored-by: Sydney Combs <[email protected]>
sycombs
approved these changes
Mar 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Compact interactive list allows users to set an index of a cell in the row that needs to be a row header via rowHeaderIndex prop. If rowHeaderIndex prop is omitted, it defaults to 0, which makes the first row cell a row header. However, if compact interactive list has only one semantic column, that would make each row to have only one cell with role = rowheader, which is redundant.
This change checks if the list has a single column, and does not assign a role = 'rowheader' to the only cell in the row.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10330