Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-table] Enable Auto Table Layout #2111

Merged
merged 3 commits into from
Apr 3, 2024
Merged

[terra-table] Enable Auto Table Layout #2111

merged 3 commits into from
Apr 3, 2024

Conversation

cm9361
Copy link
Contributor

@cm9361 cm9361 commented Mar 29, 2024

Summary

What was changed:
The ability to configure the Terra Table to use the auto layout was added to the component.

Why it was changed:
The change was made to maintain passivity with behavior that existed in the previous major version of the Terra Table component.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10336


Thank you for contributing to Terra.
@cerner/terra

@github-actions github-actions bot temporarily deployed to preview-pr-2111 March 29, 2024 20:59 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2111 April 1, 2024 13:07 Destroyed
@cm9361 cm9361 marked this pull request as ready for review April 1, 2024 16:52
@mjpalazzo
Copy link
Contributor

@cm9361 - keyboard navigation works fine with the Auto Layout example, but JAWS is not announcing anything on the example page. It does not recognize that there are headers and tables on the page so the "H" and "T" shortcuts are not working.
The new example and props must be added to the About page.

@mjpalazzo
Copy link
Contributor

@cm9361 - the example works a little better with VO on Chrome. VO announces the table role and when I use the arrow key, it announces the cell contents.

@github-actions github-actions bot temporarily deployed to preview-pr-2111 April 2, 2024 22:37 Destroyed
@mjpalazzo
Copy link
Contributor

@cm9361 - I rebooted my desktop and JAWS is functional once again. The Auto Table Layout is working great. Thanks!

@cm9361 cm9361 merged commit 1c624fb into main Apr 3, 2024
4 of 22 checks passed
@cm9361 cm9361 deleted the table-auto-layout branch April 3, 2024 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants