Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Stopped adding aria-expanded attribute to the disclosing node. #2121

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

adoroshk
Copy link
Contributor

@adoroshk adoroshk commented Apr 3, 2024

Summary

This PR stops adding "aria-expanded" attribute to the Slide panel disclosing node.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10357

… slide-panel-remove-aria-expanded-attribute
@github-actions github-actions bot temporarily deployed to preview-pr-2121 April 3, 2024 20:54 Destroyed
@adoroshk adoroshk merged commit 93c05bc into main Apr 3, 2024
22 checks passed
@adoroshk adoroshk deleted the slide-panel-remove-aria-expanded-attribute branch April 3, 2024 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants