This repository has been archived by the owner on May 24, 2024. It is now read-only.
terra-navigation-side-menu : Keyboard navigation Fixes #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadanKumarGovindaswamy
changed the title
saket2403
approved these changes
Apr 24, 2024
sugan2416
reviewed
Apr 29, 2024
There was a problem hiding this comment.
There is a difference in the background colour below the last item. Is this indication of reduced height of side menu? Is this expected ?
There was a problem hiding this comment.
I guess updated screenshot is the correct one, styles has been applied to only list items and height is adjusted to the navigation side menu container.
sugan2416
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Don't we need UX design +1 for these ?
There was a problem hiding this comment.
No we just replaced action header component. and still we have used same icon and css styles used in action header.
sugan2416
approved these changes
Apr 29, 2024
|
+1 for keyboard navigation of terra navigation side menu |
MadanKumarGovindaswamy
added
Accessibility Review Ready
and removed
Accessibility Review Required
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Added Keyboard navigation.
Remove Action Header component
Why it was changed:
Keyboard navigation was not functioning.
Action header component is not required.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10355
Thank you for contributing to Terra.
@cerner/terra