-
Notifications
You must be signed in to change notification settings - Fork 72
Added subsection support to the FlowsheetDataGrid #2132
Conversation
| **rows** | Array | Optional | [] | An array of row objects to be rendered in the section. | | ||
| **subsections** | Array | Optional | [] | An array of subsections objects to be rendered within the section. | | ||
|
||
#### Subsection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT - Shouldn't the Subsection be the same level header as Section: ### Subsection
? Looks smaller than Section and Rows headers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adoroshk - This is a good call out. I copied the structure from the Terra Table component where it originates. However, I could update this style for both components. I do think that is appropriate.
@cm9361 - I validated with Chrome, Edge, and JAWS with Edge. The KB navigation works as required. Screen reader navigation and announcements work as required. I observed one minor issue. If I am on a row in the body of the grid and press the End key (fn+right arrow on my MacBook), JAWS announces the labels of all the sections and subsections, regardless where the focus is located. For example, if focus is in column 6 row 4 in section 1, subsection 1, JAWS announces "End, Primary Contact, Test Section, Test Subsection, Test Subsection number 2, Test Section number 2, Quinzel, Harleen, Column 6" |
@mjpalazzo - Thank you for the feedback. Isn't the issue you described a known pre-existing issue? I thought we landed on the fact that the attributes were semantically correct in this scenario. If it is the pre-existing issue and we want to address it somehow, do we need a JIRA for the work. I thought we had one open previously. |
@cm9361 - you are correct. I had forgotten that this is a pre-existing issue. We may already have a Jira for it. I will follow up with Chris. As I said it is minor and does not affect funtionality, so we will deal with it in the future. Your changes are working well so I approve. |
@mjpalazzo @eawww When navigating to the Grid it announces the # of rows and columns, should it also announce the number of sections contained within the grid? I was unable to find an ARIA example that had sections to test to see how they handled it. |
@chrismichalewicz - The table does not have a concept of sections. That is functionality that we added. The screen reader would not have a way to announce that. |
Thanks @cm9361 for clarifying! It works well for me as well, great job! +1 I will also add the Functionally Reviewed label. |
Agreed...WAI and MDN have notthing to say about tables with sections. |
Summary
What was changed:
Subsection support was added to the FlowsheetDataGrid component.
Why it was changed:
The change was made to satisfy a functional requirement of a consumer of the FlowsheetDataGrid component.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10360
Thank you for contributing to Terra.
@cerner/terra