Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-tabs] Vertical tabs border fix #2133

Merged
merged 3 commits into from
Apr 17, 2024
Merged

[terra-tabs] Vertical tabs border fix #2133

merged 3 commits into from
Apr 17, 2024

Conversation

sugan2416
Copy link
Contributor

@sugan2416 sugan2416 commented Apr 12, 2024

Summary

What was changed:

  • Fixes vertical tabs right border not extending till last tab.
  • Updated example for custom label tabs.

Why it was changed:

  • Vertical tab right border was not applied.
  • Custom label display was wrapped.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10334


Thank you for contributing to Terra.
@cerner/terra

image

@sugan2416 sugan2416 force-pushed the vertical-tabs-defect branch from efb7bd9 to 1f0f619 Compare April 15, 2024 08:38
@github-actions github-actions bot temporarily deployed to preview-pr-2133 April 15, 2024 08:39 Destroyed
@sugan2416
Copy link
Contributor Author

Received +1 from Strauch,Kris in UXPLATFORM-10334

@sugan2416 sugan2416 added ⭐ UX Reviewed UX Reviewed and approved. and removed UX Review Required UX Review Ready labels Apr 17, 2024
@sugan2416 sugan2416 merged commit 7ce742d into main Apr 17, 2024
22 checks passed
@sugan2416 sugan2416 deleted the vertical-tabs-defect branch April 17, 2024 05:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📦 terra-tabs ⭐ UX Reviewed UX Reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants