This repository has been archived by the owner on May 24, 2024. It is now read-only.
Headers Swedish old translations fixed #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm9361
reviewed
Apr 15, 2024
Comment on lines
2
to
5
| "Terra.notification.dialog.hazard-low": "Information", | ||
| "Terra.notification.dialog.error": "Fel", | ||
| "Terra.notification.dialog.hazard-medium": "Obs!", | ||
| "Terra.notification.dialog.hazard-high": "Varning" |
There was a problem hiding this comment.
It seems like extra white space was added to the strings.
There was a problem hiding this comment.
Good catch, removed extra spacing in 3b3f5cb
cm9361
reviewed
Apr 15, 2024
| "Terra.notification.dialog.error": "Fel", | ||
| "Terra.notification.dialog.hazard-medium": "Varning", | ||
| "Terra.notification.dialog.hazard-high": "Avisering" | ||
| "Terra.notification.dialog.hazard-low": "Information", |
There was a problem hiding this comment.
Is this the proper translated word? It appears to be English.
There was a problem hiding this comment.
It was provided that way:
And it looks like it's the same in English and Swedish:
sycombs
reviewed
Apr 15, 2024
sycombs
approved these changes
Apr 15, 2024
Co-authored-by: Sydney Combs <[email protected]>
sdadn
reviewed
Apr 16, 2024
sdadn
approved these changes
Apr 16, 2024
Co-authored-by: Saad Adnan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces terra-notification-dialog headers Swedish translations for locales sv and sv-SE to match the new translations used elsewhere.
Testing
This change was tested using:
New headers for for locales sv and sv-SE locales.
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10362