This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-date-time-picker] Fixed accessibility issue #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adavijit
changed the title
8 tasks
sugan2416
reviewed
Apr 18, 2024
sugan2416
approved these changes
Apr 18, 2024
Co-authored-by: Sugan G <[email protected]>
sugan2416
approved these changes
Apr 18, 2024
allanxavierm
approved these changes
Apr 18, 2024
|
+1 for accessibility review for Terra Date Time Picker, as suggested the Date and Time input field are grouped. |
sycombs
reviewed
Apr 18, 2024
| /> | ||
|
|
||
| {this.state.isAmbiguousTime && this.state.dateTime ? this.renderTimeClarification() : null} | ||
| <div role="group" aria-label={ariaLabel}> |
There was a problem hiding this comment.
Do we need to add another div? Can we add the role and aria-label to the existing <div className={cx('date-facade')}> div?
There was a problem hiding this comment.
You are correct! Added the same in the root div. Also added test for the same
|
Can we also add some Jest tests for the inclusion of the |
added 3 commits
April 19, 2024 13:14
… UXPLATFORM-10229_fix
…a-framework into UXPLATFORM-10229_fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
role="group"to group theDatePickerandTimeInputcomponentWhy it was changed:
DatePickerandTimeInputcomponent was not grouped together leading to accessibility issueTesting
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10229
Thank you for contributing to Terra.
@cerner/terra