This repository has been archived by the owner on May 24, 2024. It is now read-only.
Allow break to the next/previous visual row on right/left arrow key. #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
commented
Apr 24, 2024
| * @param {number} row - an index of the currently focused semantic row. | ||
| * @returns - the index of the last semantic row in the same visual row as currently focused row. | ||
| */ | ||
| const getLastSemanticRowIndexInVisualRow = (rowsLength, numberOfColumns, flowHorizontally, row) => { |
There was a problem hiding this comment.
This functionality wasn't added in this change, it existed before. I just had to move it up in order to use in another method.
cm9361
approved these changes
Apr 25, 2024
sycombs
approved these changes
Apr 25, 2024
Co-authored-by: Sydney Combs <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes compact interactive list right/left arrow keys navigation to allow break to the next/previous visual row.
Previously, when navigation across the compact interactive list with Arrow Right/Left, it would stop at the end/beginning of the visual row. That has been changed so that once the end/start of the visual row is reached, the focus wraps to the next/previous row.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
This PR resolves:
UXPLATFORM-10339