Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Added a note to the Multiple Row Selection example in terra-table #2147

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

adoroshk
Copy link
Contributor

Summary

Added a note about accessibility requirements for sorting or another action to the Multiple Row Selection example in terra-table.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

The screenshot of the note:

Screenshot 2024-04-24 at 4 55 39 PM

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

This PR resolves:

UXPLATFORM-10379

@adoroshk adoroshk self-assigned this Apr 24, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2147 April 24, 2024 20:56 Destroyed
@adoroshk adoroshk requested review from chrismichalewicz and a team April 24, 2024 20:56
@chrismichalewicz
Copy link

@adoroshk I think including it at the very top, just below the title, or closer to the actual example in the Row Selection Interactions section would be a better placement for the message. I am leaning towards the latter perhaps right under the section title.

@github-actions github-actions bot temporarily deployed to preview-pr-2147 April 24, 2024 21:19 Destroyed
@adoroshk
Copy link
Contributor Author

@adoroshk I think including it at the very top, just below the title, or closer to the actual example in the Row Selection Interactions section would be a better placement for the message. I am leaning towards the latter perhaps right under the section title.

@chrismichalewicz Moved Note to be placed under the section title:
Screenshot 2024-04-24 at 5 18 34 PM

@chrismichalewicz
Copy link

Thanks @adoroshk I think that looks good!

@adoroshk adoroshk merged commit 989c2e1 into main Apr 25, 2024
22 checks passed
@adoroshk adoroshk deleted the terra-table-add-note branch April 25, 2024 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants