This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-folder-tree] Radio button hover updated #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… folder-tree-radio-button-hover
adoroshk
changed the title
…item css changed to match radio button circle
adoroshk
commented
May 3, 2024
Comment on lines
25
to
33
| .radio-target::before { | ||
| content: ''; | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| left: 0; | ||
| bottom: 0; | ||
| background-color: var(--terra-folder-tree-item-hover-background-color, rgb(203, 230, 247, 0.5)); | ||
| border-radius: 50%; |
There was a problem hiding this comment.
NOTE: The pseudo class is used to create a circle on hover, as the actual click area needs to stay square.
sycombs
approved these changes
May 3, 2024
adoroshk
added
⭐ UX Reviewed
sdadn
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the radio button in folder tree item hover style to be distinct from the whole item hover:
NOTE: the click area stays square.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10377