This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-slide-panel] Find closest focusable element on click #2159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Why it was changed:
When disclosing a slide panel, the element that was clicked on is stored as the "last clicked" item. On terra-buttons, a is clicked instead of the , so the last clicked item is stored as a span. This change finds the closest focusable element by repeatedly checking its parent element.
Testing
This change was tested using:
Used the Slide Panel Multiple Buttons Toggle test to verify changes
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10167
Thank you for contributing to Terra.
@cerner/terra