Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add migration for base_url #134

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

kerkness
Copy link

@kerkness kerkness commented Mar 1, 2025

It would appear that the baseUrl feature requires a database column that isn't included in the migrations.

Copy link
Contributor

@jamesdb jamesdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, perhaps we'll need to add an if (! Schema::hasColumn()) check on the up. To account for the people who added this column themselves manually.

@kerkness
Copy link
Author

kerkness commented Mar 7, 2025

Added an if to the up() method for those who already added the column.

@cesargb
Copy link
Owner

cesargb commented Mar 7, 2025

This functionality is only required when we create the MagicLink. Once it is created, it is not necessary get the url again.

There is a test that verifies its correct operation:

public function test_create_magiclink_with_custom_base_url()

If you believe that there is any reason why it is necessary to obtain the MagicLink url long after its creation and that it is justified, I see no problem in adding this field, but at the moment I cannot think of any reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants