Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add faqs page #17

Merged
merged 17 commits into from
Feb 17, 2024
Merged

feat: add faqs page #17

merged 17 commits into from
Feb 17, 2024

Conversation

danielsp45
Copy link
Member

No description provided.

Copy link

netlify bot commented Feb 14, 2024

Deploy Preview for bugsbyte ready!

Name Link
🔨 Latest commit 58e2e6d
🔍 Latest deploy log https://app.netlify.com/sites/bugsbyte/deploys/65d003d3d3458b000806ec61
😎 Deploy Preview https://deploy-preview-17--bugsbyte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielsp45 danielsp45 force-pushed the dsp/add-faqs branch 6 times, most recently from cfbca1b to c5af5e6 Compare February 15, 2024 23:24
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to maintain coherent code standards on all of our repos, it would be better if the FAQ questions were placed on a JSON file instead of being hardcoded.
Something like what is done on seium.org

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have a smooth animation when opening a faq question.
You can follow this example

Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪲💚

@danielsp45 danielsp45 dismissed MarioRodrigues10’s stale review February 17, 2024 09:34

Not feasible in the current tight schedule

@danielsp45 danielsp45 merged commit 245d53d into main Feb 17, 2024
5 checks passed
@ruilopesm ruilopesm deleted the dsp/add-faqs branch March 26, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants