feat: improve index and show partners pages design #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MarioRodrigues10
requested changes
Nov 26, 2024
|
I also suggest we delay this a bit since #538 is about to be merged and can be used on this page ! 🙌 |
AfonsoMartins26
requested review from
nunom27,
joaodiaslobo,
FilipeR13 and
AfonsoMartins26
MarioRodrigues10
requested changes
Feb 28, 2025
| </div> | ||
| <div class="sm:grid sm:grid-cols-2 sm:gap-px"> | ||
| <div class="gap-4 gap-4 px-4 sm:grid sm:grid-cols-2 sm:px-6"> |
There was a problem hiding this comment.
Suggested change
| <div class="gap-4 gap-4 px-4 sm:grid sm:grid-cols-2 sm:px-6"> | |
| <div class="gap-4 gap-4 px-4 sm:grid sm:grid-cols-1 sm:px-6"> |
There was a problem hiding this comment.
I don't quite like the spacing between the partner name, location, socials.
Add more spacing between partners.
|
Please also solve the conflicts ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the design of both show and index partners pages index
TODO:
FIX: