Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: markdown for notifications #175

Merged
merged 3 commits into from
Jan 16, 2024
Merged

feat: markdown for notifications #175

merged 3 commits into from
Jan 16, 2024

Conversation

diogogmatos
Copy link
Member

Added compatibility for markdown in the notification descriptions, this markdown is taken as a string and converted to html and then JSX. To achieve this, I installed the following (very light) npm package: markdown-to-jsx.

@diogogmatos diogogmatos added the enhancement New feature or request label Jan 16, 2024
@diogogmatos diogogmatos self-assigned this Jan 16, 2024
@diogogmatos
Copy link
Member Author

Copy link

netlify bot commented Jan 16, 2024

Deploy Preview for cesium-calendarium ready!

Name Link
🔨 Latest commit d9f7548
🔍 Latest deploy log https://app.netlify.com/sites/cesium-calendarium/deploys/65a670bd981b920008567447
😎 Deploy Preview https://deploy-preview-175--cesium-calendarium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove select-none from notifications

@diogogmatos diogogmatos dismissed MarioRodrigues10’s stale review January 16, 2024 12:13

He changed his mind, trust.

@diogogmatos diogogmatos merged commit d62449a into master Jan 16, 2024
4 checks passed
@diogogmatos diogogmatos deleted the dm/markdown branch January 16, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants