Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add shifts removed by scraper #236

Merged
merged 1 commit into from
Sep 29, 2024
Merged

fix: re-add shifts removed by scraper #236

merged 1 commit into from
Sep 29, 2024

Conversation

diogogmatos
Copy link
Member

The scraper is having problems adding the LI4 shifts to filters.json and is not picking up a shift for "Sustentabilidade Ambiental, Social e Económica". Both these problems were manually fixed in #226 and somewhere else along with other PR. However, every time the scraper runs it removes these manual changes when generating the JSON files, so we have to be aware of that from now on while the problem isn't fixed in the scraper itself.

#235 was merged by @ruilopesm because he didn't know this, so I'm adding the required changes back.

@diogogmatos diogogmatos added the bug Something isn't working label Sep 29, 2024
@diogogmatos diogogmatos self-assigned this Sep 29, 2024
Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for cesium-calendarium ready!

Name Link
🔨 Latest commit 400faa5
🔍 Latest deploy log https://app.netlify.com/sites/cesium-calendarium/deploys/66f988b65f449c0008679573
😎 Deploy Preview https://deploy-preview-236--cesium-calendarium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@diogogmatos
Copy link
Member Author

@Darguima if you could look into it, it would be nice 😅

Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, then 😅

@diogogmatos diogogmatos merged commit 42a3043 into master Sep 29, 2024
5 checks passed
@diogogmatos diogogmatos deleted the dm/fix branch September 29, 2024 17:12
@Darguima Darguima mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants