Skip to content

Commit

Permalink
Fixes for nulls in PnL cube
Browse files Browse the repository at this point in the history
  • Loading branch information
gavbrennan committed Jul 11, 2024
1 parent b746142 commit 7443e00
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ public class DeltaFlatSpreadGammaCurveStep(bool ignoreGamma = false) : IPnLAttri
{ Step, "AssetCurves" },
{ SubStep, curveName },
{ SubSubStep, "GammaFlat" },
{ PointLabel, r.MetaData[r_plIx] },
{ "PointDate", r.MetaData[r_pdIx] }
{ PointLabel, "Flat" },
{ "PointDate", endModel.VanillaModel.BuildDate }
};
resultsCube.AddRow(row, explained);

Expand Down
2 changes: 1 addition & 1 deletion src/Qwack.Models/Models/AttributionSteps/TimeRollStep.cs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public class TimeRollStep(ICurrencyProvider currencyProvider, IFutureSettingsPro
{ TradeId, r.MetaData[tidIx] },
{ TradeType, r.MetaData[tTypeIx] },
{ Step, "Fixings" },
{ SubStep, fixingDictName },
{ SubStep, fixingDictName ?? "Unknown" },
{ SubSubStep, string.Empty },
{ PointLabel, string.Empty },
{ "PointDate", endModel.VanillaModel.BuildDate }
Expand Down
2 changes: 1 addition & 1 deletion version.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<Project>
<PropertyGroup>
<VersionPrefix>0.8.57</VersionPrefix>
<VersionPrefix>0.8.58</VersionPrefix>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.8.57
0.8.58

0 comments on commit 7443e00

Please sign in to comment.