Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support job scheduling on a dedicated node #5

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

natigavriel
Copy link
Contributor

Support job scheduling on a dedicated node by exposing nodeSelector, tolerations and affinity.

@cezarguimaraes
Copy link
Owner

Thank you for the contribution @natigavriel, it LGTM! Before approving, could you please bump the minor version in helm/Chart.yaml to 0.4.0?

Also, I noticed the same nodeSelector/tolerations/affinity values apply to both the initial seed job and to the pkgsite deployment itself. This looks reasonable to me but can you confirm if this will fit your use case? If you need separate nodes for the job and for the pkgsite we should use different values.

@natigavriel
Copy link
Contributor Author

@cezarguimaraes - Thanks for your review !
I have updated the helm/Chart.yaml to 0.4.0 for your request.
We confirm that the intention was the schedule the seed job and the pkgsite deployment on the same node.
From some reason the Push Action has failed, but couldn't figure out why...
Best Regards,
Nati

@cezarguimaraes cezarguimaraes merged commit 8d67c9f into cezarguimaraes:main Feb 27, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants