Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Design System v3.x #551

Merged
merged 29 commits into from
Oct 22, 2024
Merged

Upgrade to Design System v3.x #551

merged 29 commits into from
Oct 22, 2024

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Oct 7, 2024 •
edited by flacoman91
Loading

  • Added postcss builder for icons
  • Upgraded to latest version of design system
  • Moved from Less to Sass variables
  • Move from @import to @use

Updated CCDB to latest version of CFPB Design System, and made fixes to all breaking changes.

Additions

Removals

Changes

Testing

  • View changes here: DEV2

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

- Migrated from Less to Sass
870ff9d 
- Added postcss builder for icons
- Upgraded to latest version of design system
- Moved from Less to Sass variables
- Move from @import to @use
cdhenley219 and others added 17 commits October 8, 2024 17:01
Fixed issues with imported scss files
f73eee9
Removed old dependencies and theme overrides
b7dad93
Completed initial fixes for build errors
08cfe10
Completed initial fixes for build errors2
2dde8f5
@flacoman91
stylelint less remove
0b30dfd
Fixed config with linting
9db64ea
Merge branch 'DATAP-1558-Upgrade-to-Design-System-v3.x' of github.com…
2415a62 
…:cfpb/ccdb5-ui into DATAP-1558-Upgrade-to-Design-System-v3.x
Fixed all linting errors
7a565ef
Various updates
652faa2
Updated col classes to use mixins in new design system
76070c1
incorporated design system updates into App.scss
9742a78
updated tbd components with BEM notation and new design system classes
d472a2f 
Padding update in SearchPanel
Added licensed-font() mixin to add in fonts
5710390
Fixed media query syntax to work with Sass
c4bf2d5
fixed media queries pt 2
bf82546
fixed width of filter panel by adding a new class
6756925
Changed date range label
f0c6bb0
@cdmh219 cdmh219 marked this pull request as ready for review October 18, 2024 16:42
flacoman91
flacoman91 requested changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, once you fix the one syntax regarding math.div this is good to go!

src/components/Search/SearchBar.scss Outdated Show resolved Hide resolved
cdhenley219 added 2 commits October 22, 2024 11:39
Addressed PR feedback
3516436
Merge branch 'DATAP-1558-Upgrade-to-Design-System-v3.x' of github.com…
e3f08e7 
…:cfpb/ccdb5-ui into DATAP-1558-Upgrade-to-Design-System-v3.x
flacoman91
flacoman91 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looks good!

@cdmh219 cdmh219 added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit e44a577 Oct 22, 2024
2 checks passed
@cdmh219 cdmh219 deleted the DATAP-1558-Upgrade-to-Design-System-v3.x branch October 22, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flacoman91 flacoman91 flacoman91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdmh219 @flacoman91