Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused analytics script #8632

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Delete unused analytics script #8632

wants to merge 2 commits into from

Conversation

anselmbradford
Copy link
Member

@anselmbradford anselmbradford commented Nov 7, 2024 •
edited
Loading

Removals

  • Delete unused analytics script

How to test this PR

  1. Paul to confirm these are the right files.

@anselmbradford
Copy link
Member Author

Ohhhhhhh @paulhyland I just realized that bah-explainers.js isn't used directly, but it's imported by bah-closing-disclosure-listeners.js and bah-loan-estimate-listeners.js. Those two files are identical, except they each pass in a different label to bah-explainers.js

@anselmbradford anselmbradford changed the title Delete unused analytics scripts Delete unused analytics script Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhyland paulhyland Awaiting requested review from paulhyland

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anselmbradford