-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(Pagination): Button icons hidden & Button content centered #343
Conversation
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems sensible 👍🏾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to backtrack, but this setting seems a bit questionable.
Looking at the Changeset
in Chromatic, it seems that every story's screenshot is getting regenerated - whether or not there are actual changes to the UI.
Was there something that you saw previously in Chromatic that sparked you to add this flag?
The build tests weren't passing so I pulled in I reverted the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't approve in Chromatic but will approve here and hopefully that's enough to move forward?
closes #342
Note
Changes
Screenshot