Updated code to set header on email subject based on desired logic #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcadam14
requested review from
hkeeler,
billhimmelsbach,
chynnakeys and
sthomas93
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
hkeeler
reviewed
Aug 27, 2024
src/regtech_mail_api/api.py
Outdated
| subject = f"[DEV BETA] SBL User Request for {type}" | ||
|
|
||
| header = "[BETA]" | ||
| if "cfpb" in sender_addr: |
There was a problem hiding this comment.
Suggested change
| if "cfpb" in sender_addr: | |
| sender_addr.lower().endswith('cfpb.gov'): |
...just to be extra safe and make sure we don't capture some [email protected] type address?
There was a problem hiding this comment.
Good suggestion, will update. There are some test CFPB domains we use to verify they’re not associated yet so we’ll just need to make sure they follow a *cfpb.gov format and not @cfpb-test.gov type thing. Or building a configurable list of domains that will get flagged [CFPB BETA]
There was a problem hiding this comment.
Ok changed the check to split on the @ and check for "cfpb" in the domain place. That will allow Bill's current test email accounts to stay the same format but would flag them appropriately.
hkeeler
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
Tested locally in docker by setting ENVIRONMENT: DEV in the docker-compose env variables for the mailing-api, which sent to mailpint an email with
"subject": "[DEV BETA] SBL User Request for Institution Profile Change"Then removed the ENVIRONMENT variable and changed the keycloak user to have both @cfpg.gov and @new-cfpb.gov email domains, both results ended in an email with
"subject": "[CFPB BETA] SBL User Request for Institution Profile Change"Changed account to have an email domain of "citibank.com" and had an email sent with
"subject": "[BETA] SBL User Request for Institution Profile Change"