feat: add patch for sbl institution types #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
jcadam14
reviewed
Mar 6, 2024
| case "hmda": | ||
| raise HTTPException(status_code=HTTPStatus.NOT_IMPLEMENTED, detail="HMDA type not yet supported") | ||
|
|
||
|
|
There was a problem hiding this comment.
Just the question I put in Mattermost when you lost power:
Wondering if we should be returning 204 NO_CONTENT instead of None? I've done that with a few of the endpoints in filing, and added it to the wiki for others to bring up if we want to decide on a consistent approach
Thoughts?
There was a problem hiding this comment.
yeap, the sbl case I've updated to use no_content instead
There was a problem hiding this comment.
hmda one is a question mark at the moment; if we do allow more open modifications later down the line, I'm guessing the hmda one will be more like the other normal fields, rather than the special case types dealing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #107