Ticket 115 - Update LEI to meet character restrictions #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
jcadam14
reviewed
Mar 15, 2024
src/entities/models/dto.py
Outdated
| match = re.match(r"^([a-zA-Z0-9]{20})", self.lei) | ||
| if not match: | ||
| raise ValueError( | ||
| f"Invalid lei {self.lei}. FinancialInstitution lei can only contain letters and numbers." |
There was a problem hiding this comment.
Include a mention of the 20 character limit in the error description here, in case they send 10 characters that are only letters and numbers and get confused ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #115