fix: remove scoped session since fastapi reuse threads, breaking thread local sessions #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad local sessions
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
jcadam14
approved these changes
Jan 8, 2025
lchen-2101
commented
Jan 8, 2025
| from regtech_user_fi_management.config import settings | ||
|
|
||
| engine = create_engine(str(settings.inst_conn), echo=settings.db_logging).execution_options( | ||
| schema_translate_map={None: settings.inst_db_schema} | ||
| ) | ||
| SessionLocal = scoped_session(sessionmaker(engine, expire_on_commit=False)) | ||
| SessionLocal = Session = sessionmaker(engine, expire_on_commit=False) |
There was a problem hiding this comment.
adding the Session name as a more syntactically correct term since it's not thread local anymore; clean up to remove SessionLocal later after downstream repos use the new term
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.