Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor user model, and add institutions attribute #31

Merged
merged 5 commits into from
Sep 26, 2023

Conversation

lchen-2101
Copy link
Collaborator

closes #26

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Coverage report

The coverage rate went from 82.21% to 82.73% ⬆️
The branch rate is 84%.

100% of new lines are covered.

Diff Coverage details (click to unfold)

src/entities/models/init.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dto.py

100% of new lines are covered (100% of the complete file).

src/oauth2/init.py

100% of new lines are covered (100% of the complete file).

src/oauth2/oauth2_backend.py

100% of new lines are covered (41.17% of the complete file).

src/routers/admin.py

100% of new lines are covered (92.59% of the complete file).

Copy link
Member

@hkeeler hkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just the one question about parse_institutions.

src/entities/models/dto.py Outdated Show resolved Hide resolved
@lchen-2101 lchen-2101 merged commit 6388dad into main Sep 26, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/26_update_auth_user_model branch September 26, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update user model to include institution LEIs
2 participants