Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add associated institutions endpoint, refactored domain parsing #39

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

lchen-2101
Copy link
Collaborator

closes #34

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Coverage report

The coverage rate went from 83.51% to 84.32% ⬆️
The branch rate is 86%.

95.23% of new lines are covered.

Diff Coverage details (click to unfold)

src/dependencies.py

83.33% of new lines are covered (82.35% of the complete file).
Missing lines: 43

src/entities/models/init.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dao.py

100% of new lines are covered (100% of the complete file).

src/entities/models/dto.py

100% of new lines are covered (100% of the complete file).

src/entities/repos/institutions_repo.py

100% of new lines are covered (96.82% of the complete file).

src/routers/institutions.py

100% of new lines are covered (100% of the complete file).

src/routers/institutions.py Show resolved Hide resolved
src/dependencies.py Show resolved Hide resolved
Copy link
Contributor

@aharjati aharjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lchen-2101 lchen-2101 merged commit e19d50e into main Oct 3, 2023
3 checks passed
@lchen-2101 lchen-2101 deleted the feature/34_associated_inst_status branch October 3, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demonstrate associated institutions' states
2 participants