93 synchronize linting setup between gh actions and local development #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
This PR does not seem to contain any modification to coverable code. |
lchen-2101
reviewed
Jan 18, 2024
.github/workflows/linters.yml
Outdated
There was a problem hiding this comment.
think we might also need to do the same with the toml file?
There was a problem hiding this comment.
Updated toml to remove the ^ for the ruff version
lchen-2101
reviewed
Jan 19, 2024
pyproject.toml
Outdated
| @@ -21,7 +21,7 @@ alembic = "^1.12.0" | |||
| pydantic-settings = "^2.0.3" | |||
|
|
|||
| [tool.poetry.group.dev.dependencies] | |||
| ruff = "^0.0.278" | |||
| ruff = "0.0.278" | |||
| black = "^23.7.0" | |||
lchen-2101
deleted the
93-synchronize-linting-setup-between-gh-actions-and-local-development
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93
Updated the actions for black and ruff to have versions. Black can take a compatible version definition using ~=. However ruff-action has a strict regex that only allows a specific version to be defined, no concept of keeping the latest compatible major version.