Added repo and engine code, as well as pytests #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcadam14
requested review from
hkeeler,
guffee23,
lchen-2101 and
nargis-sultani
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||
lchen-2101
reviewed
Jan 18, 2024
| filing=submission.filing, | ||
| submitter=submission.submitter, | ||
| state=SubmissionState.SUBMISSION_UPLOADED, | ||
| validation_ruleset_version="v1", |
There was a problem hiding this comment.
this should probably be null at this point, the validation process should be the one that updates it.
Updated the validation_ruleset_version on a submission nullable since it will be updated during the validation process and not when the submission is initially received. This required updated the pytest associated with the submission_repo, as well as the SubmissionDAO and the alembic script for that table.
lchen-2101
requested changes
Jan 19, 2024
lchen-2101
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Added the repos/submission_repo.py, engine/engine.py to provide model access functions as well as db session retrieval, respectively.
Added pytests to coincide with that code.