Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DAO/DTO/model_enum with discussion updates #30

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

jcadam14
Copy link
Contributor

Closes #29

As mentioned in the story, updated the following:

  • new FilingState called FILING_INSTITUTION_APPROVED
  • change the FilingType enum to be MANUAL (the only one we'll have for MVP right now)
  • add confirmation_id to SubmissionDAO
  • add contact_id to FilingDAO

The alembic scripts were already updated to include these updates.

@jcadam14 jcadam14 self-assigned this Jan 18, 2024
@jcadam14 jcadam14 linked an issue Jan 18, 2024 that may be closed by this pull request
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src
  __init__.py
  main.py
  src/entities/models
  dao.py
  dto.py
  model_enums.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Collaborator

@lchen-2101 lchen-2101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this for now. We'll probably need a separate model for the contact_info.

@lchen-2101 lchen-2101 merged commit 66ffe22 into main Jan 18, 2024
3 checks passed
@lchen-2101 lchen-2101 deleted the 29-add-dao-updates-from-discussions branch January 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DAO updates from discussions
2 participants